Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: linkify link rendering #499

Merged
merged 1 commit into from
Jan 9, 2022
Merged

🐛 FIX: linkify link rendering #499

merged 1 commit into from
Jan 9, 2022

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jan 9, 2022

Linkify links should always be treated as external links,
and the child text should be rendered (rather than using the href)

Linkify links should always be treated as external links
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #499 (9541170) into master (574b525) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   89.81%   89.82%           
=======================================
  Files          16       16           
  Lines        2072     2074    +2     
=======================================
+ Hits         1861     1863    +2     
  Misses        211      211           
Flag Coverage Δ
pytests 89.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/docutils_renderer.py 91.63% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574b525...9541170. Read the comment docs.

@chrisjsewell chrisjsewell merged commit c90be9a into master Jan 9, 2022
@chrisjsewell chrisjsewell deleted the gfm-only branch January 9, 2022 18:42
@chrisjsewell chrisjsewell restored the gfm-only branch January 9, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant