Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ REFACTOR: default_parser -> create_md_parser #474

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

chrisjsewell
Copy link
Member

The renderer option has been removed from MdParserConfig,
since it is not a configuration for the parser.
Then the default_parser function has been replaced with create_md_parser,
which directly takes the renderer class as a 2nd argument.

The `renderer` option has been removed from `MdParserConfig`,
since it is not a configuration for the parser.
Then the `default_parser` function has been replaced with `create_md_parser`,
which directly takes the renderer class as a 2nd argument.
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #474 (eb7ba56) into master (90c98aa) will increase coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files          16       16              
  Lines        2017     2009       -8     
==========================================
- Hits         1820     1813       -7     
+ Misses        197      196       -1     
Flag Coverage Δ
pytests 90.24% <84.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/directives.py 81.96% <ø> (ø)
myst_parser/docutils_.py 78.88% <75.00%> (ø)
myst_parser/main.py 89.07% <75.00%> (+0.01%) ⬆️
myst_parser/__init__.py 88.23% <100.00%> (-0.34%) ⬇️
myst_parser/cli.py 100.00% <100.00%> (ø)
myst_parser/sphinx_parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c98aa...eb7ba56. Read the comment docs.

@chrisjsewell chrisjsewell merged commit fb67af6 into master Dec 28, 2021
@chrisjsewell chrisjsewell deleted the remove-renderer branch December 28, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant