Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Remove empty "sphinx" extra #350

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

hukkin
Copy link
Member

@hukkin hukkin commented Apr 21, 2021

The comment states that this is "left in for back-compatibility", but pip doesn't fail (only warns) if installing nonexistent extras, so I believe this can be safely removed.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #350 (9532537) into master (9b1017c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          16       16           
  Lines        1882     1882           
=======================================
  Hits         1710     1710           
  Misses        172      172           
Flag Coverage Δ
pytests 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1017c...9532537. Read the comment docs.

@chrisjsewell chrisjsewell merged commit cf18116 into executablebooks:master Dec 4, 2021
@chrisjsewell
Copy link
Member

cheeers

@hukkin hukkin deleted the rm-extra branch December 4, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants