Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Note that autodoc expects rST docstrings #339

Merged
merged 3 commits into from
Mar 31, 2021
Merged

📚 DOCS: Note that autodoc expects rST docstrings #339

merged 3 commits into from
Mar 31, 2021

Conversation

john-hen
Copy link
Contributor

As suggested by @choldgraf in #228, add a warning block in the relevant section of the docs that makes it clear that docstrings are expected to be written in reStructuredText rather than Markdown when using the autodoc Sphinx extension, and link to the aforementioned issue.

@welcome
Copy link

welcome bot commented Mar 31, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #339 (3e72395) into master (bb0a35f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files          14       14           
  Lines        1826     1826           
=======================================
  Hits         1654     1654           
  Misses        172      172           
Flag Coverage Δ
pytests 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a35f...3e72395. Read the comment docs.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/using/howto.md Outdated Show resolved Hide resolved
docs/using/howto.md Outdated Show resolved Hide resolved
john-hen and others added 2 commits March 31, 2021 04:16
Co-authored-by: Chris Sewell <[email protected]>
Co-authored-by: Chris Sewell <[email protected]>
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrisjsewell chrisjsewell changed the title 📚 [DOC] Warn that autodoc expects rST docstrings, not Markdown. 📚 DOCS: Note that autodoc expects rST docstrings Mar 31, 2021
@chrisjsewell chrisjsewell merged commit 0d91280 into executablebooks:master Mar 31, 2021
@welcome
Copy link

welcome bot commented Mar 31, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@john-hen john-hen deleted the doc_autodoc_todo_markdown branch April 5, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants