-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open external URLs in a new tab #856
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
Add support to enable external links to open in a new tab. Expose the configuration option myst_links_external_new_tab, which if set will set all URL links to open in a new tab on the browser. Besides that, we allow the user to set the target and rel attributes when using the extension inline_attrs (executablebooks#820). Closes executablebooks#820 Closes executablebooks#856 Signed-off-by: Marjus Cako <[email protected]>
This feature will be nice to have. Something I was looking for as well. |
Add support to enable external links to open in a new tab. Expose the configuration option myst_links_external_new_tab, which if set will set all URL links to open in a new tab on the browser. Besides that, we allow the user to set the target and rel attributes when using the extension inline_attrs (executablebooks#820). Closes executablebooks#820 Closes executablebooks#856 Signed-off-by: Marjus Cako <[email protected]>
Add support to enable external links to open in a new tab. Add the configuration option `myst_links_external_new_tab`, which if set to `True` will set all URL links to open in a new tab on the browser. Also allow the user to set the `target` and `rel` attributes on links, when using the `inline_attrs` extension. Co-authored-by: Chris Sewell <[email protected]>
This improvement relies on an unreleased version of MystParser. This means pointing to a specific Git commit hash instead of the base version of myst-parser. See executablebooks/MyST-Parser#856 Signed-off-by: Tiago Pereira <[email protected]>
This improvement relies on an unreleased version of MystParser. This means pointing to a specific Git commit hash instead of the base version of myst-parser. See executablebooks/MyST-Parser#856 Signed-off-by: Tiago Pereira <[email protected]>
This improvement relies on an unreleased version of MystParser. This means pointing to a specific Git commit hash instead of the base version of myst-parser. See executablebooks/MyST-Parser#856 Signed-off-by: Tiago Pereira <[email protected]>
Describe the feature you'd like to request
Currently there is no way by using the Markdown to set a link to open on a new tab, as it is also described in #820. I would like to add to that, so that we create a new configuration option to add to all external URLs the setting to open to a new tab.
Describe the solution you'd like
I propose that we add a configuration option, e.g.,
external_links_new_tab
, which if set to true, all the rendered link_url will contain the attributestarget=_blank
andrel="noreferer noopener"
.As a bonus to the above, we will enable the
target
andrel
keys to be configurable from the user, so that if they want to add only some of the URLs to be opened in a new tab, to be able to do so.Describe alternatives you've considered
No response
The text was updated successfully, but these errors were encountered: