Twilio delivery method allows Notifier to handle errors #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary:
This PR allows handling Twilio errors in the Notifier. This is very similar to how other DeliveryMethods do it.
eg in fcm.rb
noticed/lib/noticed/delivery_methods/fcm.rb
Lines 18 to 23 in 1514ae3
Description:
Twilio has very verbose errors (including error codes) that allows API callers to do follow up actions.
eg: Error code 21211 shows that the number is invalid. In this case, we can mark a phone number as invalid to prevent further calls to Twilio.
Testing:
Added a test for the added code.
Screenshots (if applicable):
Also added example in the Twilio documentation
Checklist:
Additional Notes: