Discourage developers to check in their p8 file #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
commented
Nov 6, 2023
|
I think this looks good. We will need a CHANGELOG entry for this and it will be a breaking change, so probably requires a major release. |
|
Would you prefer to do a minor release with a deprecation warning? We are technically changing the property name - using the old (existing) one could log a warning. |
|
@excid3, I added a CHANGELOG entry and merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending iOS notifications developers must provide their p8 certificate file. The default codepath looks in the Rails app/ directory which requires checking in the file to source control.
This PR moves the default location to the credentials file.
Note that it is a breaking change for existing apps. I renamed the option to make it more clear what is expected.
We could keep the old method around but raise a deprecation warning when used. Or force a breaking change on folks to ensure the file isn't checked in.