Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #313

Merged
merged 42 commits into from
Jan 15, 2024
Merged

V2 #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
33d4290
Always use json column type to simplify model generator. Postgres use…
excid3 Oct 12, 2023
f93fc2d
Add record polymorphic association to model for simpler associations
excid3 Oct 12, 2023
55aa7bf
Add record association
excid3 Oct 12, 2023
b7e9207
Add support for delivery_by config blocks (#315)
excid3 Oct 21, 2023
22e8fd5
Update appraisals for Rails 6.1+ and Ruby 3+
excid3 Oct 21, 2023
507794f
Replace http gem dependency with net/http
excid3 Oct 21, 2023
49675d6
Remove Rails 6 polyfills now that we support 6.1+
excid3 Oct 21, 2023
3c5713a
Rename to Notifiers
excid3 Oct 21, 2023
255ed39
Clean up initializers for polyfills and http gem
excid3 Oct 21, 2023
9f5d22f
Standardize to Ruby 3.0
excid3 Oct 21, 2023
a870e98
Use main branch on CI
excid3 Oct 21, 2023
68373d3
Merge main
excid3 Oct 21, 2023
9992d18
Extract record key from params and save it to the record database column
excid3 Oct 25, 2023
d1c5376
Rename notification to notifier generator
excid3 Dec 7, 2023
47b032d
WIP version 2
excid3 Dec 22, 2023
a0a9c4e
Use Rails 6.1 for migrations
excid3 Dec 22, 2023
a94c79a
Update test schema for Rails 6.1 compat
excid3 Dec 22, 2023
09de357
Add Rails 6.1 back to CI
excid3 Dec 22, 2023
fe42e81
Add linux to lock
excid3 Dec 22, 2023
10ef5bb
Update lockfiles
excid3 Dec 22, 2023
1b2b6b1
Update gemfile
excid3 Dec 22, 2023
e08428c
Add linux to rails 6.1 lockfile
excid3 Dec 22, 2023
922b037
Remove version from schema
excid3 Dec 22, 2023
7d76d00
Remove deliver transaction
excid3 Dec 22, 2023
3e33fc0
Use test queue adapter because async adapter has a bug in Rails https…
excid3 Dec 22, 2023
c222cc0
Add read & seen to notifications
excid3 Dec 22, 2023
3d28b80
Standardize
excid3 Dec 22, 2023
ee93969
Add wait, wait_until, queue, and priority for delivery methods to mat…
excid3 Dec 24, 2023
d23a324
Use string for queue name assertion
excid3 Dec 24, 2023
850bff3
Skip priority test on Rails 6.1
excid3 Dec 24, 2023
8f2e9c8
Add Ruby 3.3 to CI
excid3 Dec 26, 2023
9493af6
Add upgrade guide
excid3 Jan 2, 2024
a7da9a2
Merge branch 'v2' of github.com:excid3/noticed into v2
excid3 Jan 2, 2024
9073d5c
Add some more things
excid3 Jan 2, 2024
e5553d3
Refactor
excid3 Jan 2, 2024
04a3ee8
Start updating docs
excid3 Jan 3, 2024
dbe565e
Order default params value before serialize
excid3 Jan 3, 2024
d754cf0
More upgrade notes
excid3 Jan 15, 2024
963d1e3
Support if/unless for bulk deliveries
excid3 Jan 15, 2024
8daeec5
Update test dependencies
excid3 Jan 15, 2024
5eaade5
Update github configs
excid3 Jan 15, 2024
e80cb94
Merge branch 'main' into v2
excid3 Jan 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
blank_issues_enabled: false
contact_links:
- name: Get Help
url: https://github.com/excid3/noticed/discussions/new?category=help
about: If you can't get something to work the way you expect, open a question in our discussion forums.
- name: Feature Request
url: https://github.com/excid3/noticed/discussions/new?category=ideas
about: 'Suggest any ideas you have using our discussion forums.'
- name: Bug Report
url: https://github.com/excid3/noticed/issues/new?body=%3C%21--%20Please%20provide%20all%20of%20the%20information%20requested%20below.%20We%27re%20a%20small%20team%20and%20without%20all%20of%20this%20information%20it%27s%20not%20possible%20for%20us%20to%20help%20and%20your%20bug%20report%20will%20be%20closed.%20--%3E%0A%0A%2A%2AWhat%20version%20of%20Noticed%20are%20you%20using%3F%2A%2A%0A%0AFor%20example%3A%20v2.0.4%0A%0A%2A%2AWhat%20version%20of%20Rails%20are%20you%20using%3F%2A%2A%0A%0AFor%20example%3A%20v7.1.1%0A%0A%2A%2ADescribe%20your%20issue%2A%2A%0A%0ADescribe%20the%20problem%20you%27re%20seeing%2C%20any%20important%20steps%20to%20reproduce%20and%20what%20behavior%20you%20expect%20instead.
about: If you've already asked for help with a problem and confirmed something is broken with Noticed itself, create a bug report.
43 changes: 11 additions & 32 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,22 @@ on:
push:
branches:
- main

jobs:
sqlite:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
Expand Down Expand Up @@ -60,23 +53,16 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
Expand Down Expand Up @@ -116,30 +102,23 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true

services:
postgres:
image: postgres:12
image: postgres:16
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: password
Expand Down
2 changes: 1 addition & 1 deletion .standard.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ruby_version: 2.7
ruby_version: 3.0
ignore:
- '**/*':
- Style/HashSyntax
8 changes: 0 additions & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
appraise "rails-5-2" do
gem "rails", "~> 5.2.0"
end

appraise "rails-6" do
gem "rails", "~> 6.0.0"
end

appraise "rails-6-1" do
gem "rails", "~> 6.1.0"
end
Expand Down
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
### Unreleased

### 2.0.0

* [Breaking] Noticed now provides its own models for managing notifications. Migrate existing model(s) to use the new Noticed tables.

TODO - add migration example

* [Breaking] Noticed::NotificationChannel has been removed. Use an ActionCable channel in your application instead.
* [Breaking] Twilio has been renamed to `twilio_messaging` to provide support for other Twilio services in the future.
* [Breaking] Vonage / Nexmo has been renamed to `vonage_sms` to provide support for other Vonage services in the future.

```ruby
class NotificationChannel < ApplicationCable::Channel
def subscribed
stream_for current_user
end

def unsubscribed
stop_all_streams
end
end
```

* `Notifications` have now been renamed to `Notifiers` and now inherit from the
* Email delivery method now supports args
* Support html safe translations for Rails 7+

### 1.6.3
Expand Down
Loading