Remove the usage of instance variables from Noticed::Base

[manojmj92]

Since we are attaching record and recipient to the Notification object just before the delivery, there is no longer a requirement to set these from within Noticed::Base.

recipient was already being passed as an argument to run_delivery_method. Now record, if it exists (ie, the database record) is also passed as an argument to the same run_delivery_method method.

Both of these will now be available in the perform method of DeliveryMethods::Base, where it will be attached to the @notification object.

I'm trying implement #89, and this cleanup helps :)

[manojmj92]

@excid3 Hi Chris, this is ready for review 🙂

[silva96]

Hey I'm a bit too late here but, removing @record on the database notification (former line 80) breaks my code:

notification = MyNotification.with(my_param: 'something').deliver(some_user)
if some_user.special_thing
  notification.record.mark_as_read!
end

In the new code, calling notification.record is nil

@excid3 @manojmj92

[excid3]

#176

[silva96]

thanks @excid3 i'll have to wait then until that is merged.