Adding the ability to surface http2 error to the app and closing the …

…apnotic connection (#503)

docs/delivery_methods/ios.md

@@ -30,6 +30,7 @@ class CommentNotifier < ApplicationNotifier
     config.key_id = Rails.application.credentials.dig(:ios, :key_id)
     config.team_id = Rails.application.credentials.dig(:ios, :team_id)
     config.apns_key = Rails.application.credentials.dig(:ios, :apns_key)
+    config.error_handler = ->(exception) { ... }
   end
 end
 ```
@@ -66,6 +67,9 @@ end
 
   Set this to `true` to use the APNS sandbox environment for sending notifications. This is required when running the app to your device via Xcode. Running the app via TestFlight or the App Store should not use development.
 
+* `error_handler` - *Optional*
+  A lambda to allow your app to handle Apnotic errors.
+
 ## Gathering Notification Tokens
 
 A recipient can have multiple tokens (i.e. multiple iOS devices), so make sure to return them all.
@@ -106,7 +110,7 @@ class CommentNotifier < ApplicationNotifier
 end
 ```
 
-Another common action is to update the badge after a user reads a notification. 
+Another common action is to update the badge after a user reads a notification.
 
 This is a great use of the Noticed::Ephemeral class. Since it's all in-memory, it will perform the job and not touch the database.
 

lib/noticed/delivery_methods/ios.rb

@@ -16,6 +16,7 @@ def deliver
           connection_pool.with do |connection|
             response = connection.push(apn)
             raise "Timeout sending iOS push notification" unless response
+            connection.close
 
             if bad_token?(response) && config[:invalid_token]
               # Allow notification to cleanup invalid iOS device tokens
@@ -62,6 +63,9 @@ def new_connection_pool(development:)
         handler = proc do |connection|
           connection.on(:error) do |exception|
             Rails.logger.info "Apnotic exception raised: #{exception}"
+            if config[:error_handler].respond_to?(:call)
+              notification.instance_exec(exception, &config[:error_handler])
+            end
           end
         end
 

test/delivery_methods/ios_test.rb

@@ -18,6 +18,9 @@ def push(apn)
       @deliveries.push(apn)
       @response
     end
+
+    def close
+    end
   end
 
   class FakeResponse