Don't remove record from params with ephemeral notifications (#448)

excid3 · May 23, 2024 · 2a3dbb0 · 2a3dbb0
1 parent 923d390
commit 2a3dbb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/app/models/concerns/noticed/deliverable.rb b/app/models/concerns/noticed/deliverable.rb
@@ -70,8 +70,12 @@ def param(*names)
       end
 
       def with(params)
-        record = params.delete(:record)
-        new(params: params, record: record)
+        if self < Ephemeral
+          new(params: params)
+        else
+          record = params.delete(:record)
+          new(params: params, record: record)
+        end
       end
 
       def deliver(recipients = nil, **options)

diff --git a/test/ephemeral_notifier_test.rb b/test/ephemeral_notifier_test.rb
@@ -13,4 +13,8 @@ class EphemeralNotifierTest < ActiveSupport::TestCase
       perform_enqueued_jobs
     end
   end
+
+  test "ephemeral has record shortcut" do
+    assert_equal :foo, EphemeralNotifier.with(record: :foo).record
+  end
 end