-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version completion of Mark Fixed #1288
Comments
Yeah that is kind of annoying, it's an angular thing. I could debounce it longer of which I thought I had it set to a half second. |
Why are we even changing it before it's sent to the server? Seems like a very weird thing to be changing someone's input as they are typing. |
For 1.0.0.0 to 1.0.0-0 it's useful as 1.0.0.0 isn't accepted, but I think these should only be modified after clicking on send. Or at least only for full versions. |
…so fixed bug where version might not be saved.
I've resolved this issue and a different bug where the version can be lost in the latest nightly. We now wait a full second before applying any changes. If you click submit super fast, you may need to click it again as validation will fail and then it will be converted. We can work towards improving this more but it's way better than what it was (just getting lost) For context, the api endpoint accepts any string and will try to parse it to semver. I wanted this ui because it's the first touch point around how our version system works. I wanted to let the user know how we would treat their versions behind the scenes. |
If you type 1.0, it's completed to 1.0.0 automatically. But this is not a good completion if you want to write 1.0.1. The completion of 1.0 to 1.0.0 should only occur after pressing Mark Fixed button.
The text was updated successfully, but these errors were encountered: