You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Keyboard arrow keys stop to move elements when the group includes an elbow arrow #8387
Having looked at the code I concluded that this is not a bug, but a too restrictive feature. However, we can make the restriction more targeted/relaxed even without touching the arrow move logic. The keyboard move should only be restricted if the start or end element is not part of the selection.
The reason will be displayed to describe this comment to others. Learn more.
This solves the specific issue this PR references, but don't we want to allow moving elbow arrows bound on only one end if the connected end boundable is also in the selection @dwelle ?
This solves the specific issue this PR references, but don't we want to allow moving elbow arrows bound on only one end if the connected end boundable is also in the selection @dwelle ?
I agree - that would be ideal, however, this PR is already a big improvement.
This solves the specific issue this PR references, but don't we want to allow moving elbow arrows bound on only one end if the connected end boundable is also in the selection @dwelle ?
I agree - that would be ideal, however, this PR is already a big improvement.
I've modified the solution to include @mtolmacs's case as well. I think this is much better from a UX perspective.
I can live with this, but I defer to @dwelle to give final approval. Thanks for the fix and flexibility!
Haven't checked code, but from checking the preview it looks now arrow behavior is aligned to dragging behavior, which is what we want? Or is there something I'm missing?
I can live with this, but I defer to @dwelle to give final approval. Thanks for the fix and flexibility!
Haven't checked code, but from checking the preview it looks now arrow behavior is aligned to dragging behavior, which is what we want? Or is there something I'm missing?
Yes, it makes sense to have the same behavior IMO.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Keyboard arrow keys stop to move elements when the group includes an elbow arrow #8387
Having looked at the code I concluded that this is not a bug, but a too restrictive feature. However, we can make the restriction more targeted/relaxed even without touching the arrow move logic. The keyboard move should only be restricted if the start or end element is not part of the selection.