Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support onPointerUp prop #7638

Merged
merged 3 commits into from
Feb 1, 2024
Merged

feat: support onPointerUp prop #7638

merged 3 commits into from
Feb 1, 2024

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Feb 1, 2024

closes #7617

So the doc mentioned the prop onPointerUp but it was never added in the package hence adding it now.

Thanks @Soliden-96 for the report

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Feb 1, 2024 0:26am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Feb 1, 2024 0:26am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Feb 1, 2024 0:26am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 0:26am

Copy link

github-actions bot commented Feb 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.24% / 70% 45684 / 70015
🔴 Statements 65.24% / 70% 45684 / 70015
🔴 Functions 66.39% / 68% 1395 / 2101
🟢 Branches 80.11% / 70% 5652 / 7055
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/index.tsx 79.7% 89.47% 80% 79.7% 93-97, 153-202
packages/excalidraw/types.ts 100% 100% 100% 100%
packages/excalidraw/components/App.tsx 68.88% 75.15% 67.56% 68.88% 453-454, 563-572, 666-667, 685-686, 706-766, 769-775, 778-781, 784-860, 863-882, 885-890, 898-908, 910-911, 916-917, 921-923, 937, 944-1202, 1262-1263, 1274-1275, 1302-1304, 1314-1359, 1385, 1395, 1402-1405, 1442-1443, 1525-1534, 1539-1553, 1557-1603, 1674-1679, 1708-1713, 1716-1746, 1754-1779, 1782-1791, 1794-1906, 1909-1917, 1926-1939, 1942-1968, 1971-2042, 2045-2085, 2131-2132, 2150-2151, 2188-2189, 2193-2194, 2210-2217, 2222-2235, 2241-2242, 2247-2255, 2257-2265, 2277, 2317-2318, 2340-2341, 2348, 2409-2411, 2414-2419, 2424-2425, 2461-2469, 2474-2483, 2521-2522, 2605-2606, 2610, 2613-2614, 2622-2625, 2634-2647, 2653-2656, 2659, 2661-2662, 2669-2670, 2676-2677, 2680-2681, 2689-2690, 2693-2694, 2697-2700, 2703-2706, 2717-2725, 2730-2731, 2787-2788, 2802-2808, 2814-2822, 2826-2834, 2838-2839, 2842-2875, 2878-2890, 2901-2902, 2913-2914, 2931-2935, 2939-2942, 2949-2951, 2969-2976, 2979, 2981-2986, 2990-2992, 3013-3014, 3021-3023, 3025-3048, 3074, 3080, 3132-3133, 3150-3152, 3174-3175, 3181-3184, 3190-3265, 3337-3338, 3343-3346, 3409, 3419-3437, 3440-3446, 3449-3450, 3456-3469, 3555-3556, 3558-3559, 3564-3566, 3574-3575, 3598-3612, 3617-3636, 3659-3660, 3720, 3739-3743, 3754-3755, 3758-3762, 3764-3765, 3767-3770, 3795-3796, 3805-3807, 3809, 3888-3891, 3913-3915, 3925-3926, 3928-3948, 3951-3957, 3974-3977, 3983-3986, 3996-4003, 4007-4008, 4013, 4041-4045, 4049, 4054-4055, 4060-4064, 4096-4097, 4100-4101, 4109-4113, 4117-4127, 4132-4159, 4164-4175, 4241, 4267-4268, 4360, 4550-4551, 4554-4555, 4563, 4575, 4577-4578, 4619-4623, 4678-4684, 4690-4753, 4796, 4845, 4871, 4878-4879, 4888-4891, 4921, 4969-4972, 4975-4981, 4983-4986, 5001-5010, 5013-5014, 5095-5096, 5099, 5101-5102, 5108-5110, 5112, 5121, 5143-5148, 5150-5153, 5157-5158, 5168-5268, 5272-5273, 5287-5288, 5342-5343, 5370-5371, 5404-5430, 5437-5438, 5460-5461, 5480, 5482-5525, 5530-5531, 5533-5534, 5550-5551, 5557-5558, 5562-5565, 5568-5569, 5584-5611, 5619-5620, 5624-5627, 5629-5633, 5651-5655, 5701-5706, 5708-5710, 5726, 5728-5739, 5764-5767, 5811, 5828-5829, 5831-5854, 5869-5870, 5981-6009, 6074-6078, 6102-6103, 6123-6124, 6218, 6224-6225, 6248-6267, 6282, 6415, 6437-6478, 6482-6532, 6547, 6556, 6590-6596, 6611-6613, 6755-6758, 6782-6816, 6829, 6831-6838, 6852, 6854-6861, 6868-6871, 6879-6884, 6911-6912, 6917-6919, 6922-6923, 6948-6949, 6977-6978, 7061-7062, 7111-7124, 7184-7187, 7213-7214, 7245-7246, 7259, 7277-7283, 7290-7293, 7316-7321, 7392-7395, 7401, 7416-7423, 7426-7433, 7490, 7564-7565, 7586-7588, 7591, 7605-7629, 7735-7753, 7763-7802, 7815-7816, 7825-7832, 7846-7858, 7871-7876, 7932-7958, 7960-7961, 8035-8039, 8046, 8048-8084, 8113, 8164, 8183-8185, 8210-8215, 8217-8218, 8223-8225, 8228-8248, 8262-8263, 8269-8278, 8283, 8287-8291, 8300-8304, 8307-8312, 8316-8323, 8353, 8355-8359, 8361-8371, 8387-8389, 8400-8408, 8412-8448, 8451-8522, 8530, 8548-8555, 8557-8573, 8588-8610, 8629-8631, 8676-8677, 8707-8708, 8724, 8801-8804, 8806-8822, 8824-8828, 8840-8841, 8851-8867, 8901-8902, 8906-8918, 8928, 8930-8933, 8935-8936, 8976, 8997-8998, 9024, 9027, 9067, 9081-9088, 9105-9106, 9138-9141, 9229-9236, 9262-9263, 9304-9358, 9406-9407, 9416-9419, 9424-9425, 9446-9448, 9450-9454, 9492
Generated in workflow #1773

@ad1992 ad1992 enabled auto-merge (squash) February 1, 2024 12:26
@ad1992 ad1992 merged commit 90ad885 into master Feb 1, 2024
9 checks passed
@ad1992 ad1992 deleted the aakansha/pointerup branch February 1, 2024 12:26
IvanLi-CN pushed a commit to IvanLi-CN/excalidraw that referenced this pull request Feb 24, 2024
* feat: support onPointerUp prop

* update changelog

* Update packages/excalidraw/CHANGELOG.md

Co-authored-by: David Luzar <[email protected]>

---------

Co-authored-by: David Luzar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onPointerDown fires correctly but onPointerUp doesn't
2 participants