Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: frame name editing inconvenience #7437

Merged
merged 1 commit into from
Jan 21, 2024
Merged

fix: frame name editing inconvenience #7437

merged 1 commit into from
Jan 21, 2024

Conversation

ryan-di
Copy link
Member

@ryan-di ryan-di commented Dec 14, 2023

close #7363

@ryan-di ryan-di requested a review from dwelle December 14, 2023 09:13
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Dec 14, 2023 9:13am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Dec 14, 2023 9:13am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 14, 2023 9:13am

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.38% / 70% 44641 / 68275
🔴 Statements 65.38% / 70% 44641 / 68275
🔴 Functions 66.48% / 68% 1367 / 2056
🟢 Branches 80.06% / 70% 5541 / 6921
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/frame.ts 65.16% 70.12% 74.07% 65.16% 40-55, 60-74, 89-96, 99-101, 127-128, 149-166, 169-188, 196-209, 255, 273-284, 287-300, 321-330, 338-345, 358-360, 412, 414-415, 446-460, 463-470, 511-520, 530-531, 535, 554-555, 560-567, 583, 601, 619-623, 625-654, 664-665
Generated in workflow #1353

dwelle
dwelle approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwelle dwelle merged commit 4997624 into master Jan 21, 2024
8 of 9 checks passed
@dwelle dwelle deleted the frame-name-edit branch January 21, 2024 19:55
IvanLi-CN pushed a commit to IvanLi-CN/excalidraw that referenced this pull request Feb 24, 2024
@ryan-di @IvanLi-CN
fix: frame name editing inconvenience (excalidraw#7437)
562ba97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelle dwelle dwelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frame name field bug
2 participants
@ryan-di @dwelle