Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSlint implementation #441

Merged
merged 53 commits into from
May 26, 2015
Merged

TSlint implementation #441

merged 53 commits into from
May 26, 2015

Conversation

eonarheim
Copy link
Member

Closes #394, does not include the tests or the sandbox code. If everyone is okay with that this can be merged

@eonarheim
Starting #394 #395 Basic implementation started
caedff7
@eonarheim
Finish Actor.ts
c9989f2
@eonarheim
Finish Algebra.ts
19bcb46
@eonarheim
Finish Animation.ts
5344e4f
@eonarheim
Finish Binding.ts
2dadf16
@eonarheim
Finish Camera.ts
f911d00
@eonarheim
Finish Camera.ts
8fbd93d
@eonarheim
Finish CollisionPair.ts
2dc82b6
@eonarheim
Finish Color.ts
91253c8
@eonarheim
Finish EasingFunctions.ts
e8ccc18
@eonarheim
Fix underscorePrefixRule, Camera.ts, Actor.ts, Engine.ts, Binding.ts
f3d719b
@eonarheim
Finish EventDispatcher.ts
08fd30a
@eonarheim
Finish Events.ts
54ed80f
@eonarheim
Finish Group.ts
9066a74
@eonarheim
Finish Label.ts
ad1fcdd
@eonarheim
Finish Loader.ts
557bc7c
@eonarheim
Finish Log.ts
ae4d494
@eonarheim
Actually finish Log.ts
a612910
@eonarheim
Finish MonkeyPatch.ts
1eb853f
@eonarheim
Finish Particles.ts
6e5af2c
@eonarheim
Finish Polygon.ts
ffccd4a
@eonarheim
Finished Promises.ts
1e6952c
@eonarheim
merge master to tslint
f4211a0
@eonarheim
Finish Resource.ts
aaf45f8
@eonarheim
Finish Scene.ts
baf9d7a
@eonarheim
Finish Sound.ts, fix underscorePrefixRule to handle no access modifiers
1e0074b
@eonarheim
Finish Sprite.ts
c26bd41
@eonarheim
Finish SpriteEffects.ts
8e756d2
@eonarheim
Finish SpriteSheet.ts
9f3f1c8
@eonarheim
Finish TileMap.ts
466c1a5
@kamranayub
Copy link
Member

+1

On Mon, May 25, 2015, 20:18 Erik Onarheim [email protected] wrote:

Closes #394 #394, does
not include the tests or the sandbox code. If everyone is okay with that

this can be merged

You can view, comment on, or merge this pull request online at:

#441
Commit Summary

  • Starting Run TS Lint to enforce code quality, fail build otherwise #394 Enable eslint rule equivalent to ts-lint completed-docs rule #395 Basic implementation started
  • Finish Actor.ts
  • Finish Algebra.ts
  • Finish Animation.ts
  • Finish Binding.ts
  • Finish Camera.ts
  • Finish Camera.ts
  • Finish CollisionPair.ts
  • Finish Color.ts
  • Finish EasingFunctions.ts
  • Fix underscorePrefixRule, Camera.ts, Actor.ts, Engine.ts, Binding.ts
  • Finish EventDispatcher.ts
  • Finish Events.ts
  • Finish Group.ts
  • Finish Label.ts
  • Finish Loader.ts
  • Finish Log.ts
  • Actually finish Log.ts
  • Finish MonkeyPatch.ts
  • Finish Particles.ts
  • Finish Polygon.ts
  • Finished Promises.ts
  • merge master to tslint
  • Finish Resource.ts
  • Finish Scene.ts
  • Finish Sound.ts, fix underscorePrefixRule to handle no access
    modifiers
  • Finish Sprite.ts
  • Finish SpriteEffects.ts
  • Finish SpriteSheet.ts
  • Finish TileMap.ts
  • Finish Action.ts
  • Finish ActionContext.ts
  • Finish IActionable.ts
  • Finish BoundingBox.ts
  • Finish DynamicTree.ts
  • Finish DynamicTreeCollisionResolver.ts
  • Finish ICollisionResolver.ts
  • Finish NaiveCollisionResolver.ts
  • Finish Gamepad.ts
  • Finish IEngineInput.ts
  • Finish Input Folder
  • Finish files I missed in core
  • Finish Module Folder
  • Actually finish Module folder
  • Finish SortedList.ts

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#441.

@jedeen
Copy link
Member

jedeen commented May 25, 2015

We can deal with those in the next milestone. (#442 #443)

eonarheim added a commit that referenced this pull request May 26, 2015
@eonarheim
Merge pull request #441 from excaliburjs/tslint-revised
f8c12cb 
TSlint implementation
@eonarheim eonarheim merged commit f8c12cb into master May 26, 2015
@eonarheim eonarheim deleted the tslint-revised branch May 26, 2015 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run TS Lint to enforce code quality, fail build otherwise
3 participants
@eonarheim @kamranayub @jedeen