Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move CONTRIBUTING.md and CODE_OF_CONDUCT.md to repository root #3130

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Autsider666
Copy link
Contributor

@Autsider666 Autsider666 commented Jul 19, 2024

I've had this idea for quite a while now, but never acted on it until a potential contributor asked how to contribute on discord.
I'm a big fan of best practices, so I'm glad that there's even one for the position of CONTRIBUTING.md and CODE_OF_CONDUCT.md

  • Set PR to squash all the commits if it's not already so (You can only change 1 file per commit in the browser)

@Autsider666
Copy link
Contributor Author

There's a badge for code of conduct, mentioned here by the way:
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](code_of_conduct.md)

@eonarheim
Copy link
Member

@Autsider666 I agree, I think having these at the root is much better than in the .github folder. I'm soliciting some feedback from other maintainers but this seems like a solid idea

@Autsider666
Copy link
Contributor Author

Just realized that I completely forgot to even create an issue to see if it was even needed. Sorry, will try to remember that next time :D

@Autsider666
Copy link
Contributor Author

In case this gets merged: Redirect the new https://excaliburjs.com/contributing url (as seen here)

@eonarheim
Copy link
Member

@Autsider666 Good call out, will do.

I'll need to update a few other repos/links that point at the old contributing location so I'm planning on doing this when I have a hour to rip through them all to point at the top level redirector https://excaliburjs.com/contributing

Copy link

github-actions bot commented Oct 3, 2024

This PR hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Oct 3, 2024
@eonarheim
Copy link
Member

eonarheim commented Oct 3, 2024 via email

@github-actions github-actions bot removed the stale This issue or PR has not had any activity recently label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants