-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: YSortComponent #3057
base: main
Are you sure you want to change the base?
feat: YSortComponent #3057
Conversation
Deploying excaliburjs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattjennings Looks completely reasonable to me, no notes! Let me know if you're ready to merge
We spoke offline, we are going to test this with some Tilemap use cases first before merging |
After discussion on discord, we decided:
Further ideas from myself since discussion:
class MyScene extends ex.Scene {
constructor() {
super({
ySort: true,
// and/or ?
ySort: { enabled: true, ...otherConfig }
})
}
}
class MyActor {
constructor() {
super({
// ySort config defaults to scene's ySort
})
}
} |
This PR hasn't had any recent activity lately and is being marked as stale automatically. |
===:clipboard: PR Checklist :clipboard:===
==================
Changes:
YSortComponent that adjusts z-index based on its global Y position. This can be used on an
Actor with the new
ySort
configuration in the constructor, or added as a component to an Entity.CleanShot.2024-05-11.at.18.09.35.mp4
Open to any feedback or suggestions on functionality / API.