Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3047] Animation glitch cause by uninitialized state #3048

Merged
merged 2 commits into from
May 5, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented May 5, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3047

After the performance update to ImageRenderer in v0.29.2 there was uninitialized shared state that leaks between draw calls, which Rasters are especially susceptible to based on the call pattern.

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label May 5, 2024
Copy link

cloudflare-workers-and-pages bot commented May 5, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceae67c
Status: ✅  Deploy successful!
Preview URL: https://6bd25b85.excaliburjs.pages.dev
Branch Preview URL: https://fix-polygon-glitch.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 8058188 into main May 5, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the fix/polygon-glitch branch May 5, 2024 15:22
eonarheim added a commit that referenced this pull request May 5, 2024
Closes #3047

After the performance update to `ImageRenderer` in v0.29.2 there was uninitialized shared state that leaks between draw calls, which `Raster`s are especially susceptible to based on the call pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.29.2 introduces Graphics (Polygon / Circle) glitch in combination with Animations
1 participant