New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Overriding existing components #2686

Merged

eonarheim merged 2 commits into main from bugfix/override-existing-components

Jul 5, 2023

Member

eonarheim commented Jul 5, 2023 •

edited

Loading

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Fixes #2685

Overriding existing components did not work because of deferred removal, this change forces an immediate removal when overriding.

eonarheim added 2 commits

July 4, 2023 19:38


          fix: Overriding existing components

828c94c


          Add test

10cc10e

eonarheim merged commit e9a04e5 into main

eonarheim deleted the bugfix/override-existing-components branch

July 5, 2023 01:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet