Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2608] macos meta key issue #2661

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR adds a fix suggested from SO, where release of the meta key causes the release of all keys

Closes #2608

Following the repro

  • Press A key
  • Press Command key
  • Release A key
  • Release Command key

macos-meta

@eonarheim eonarheim merged commit 4ebacc7 into main Jun 14, 2023
@eonarheim eonarheim deleted the bugfix/2608-macos-meta-key branch June 14, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard.isHeld returns true when the key is released with Command key held
1 participant