Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsconfig): restrict types array #2160

Merged
merged 3 commits into from
Dec 18, 2021
Merged

fix(tsconfig): restrict types array #2160

merged 3 commits into from
Dec 18, 2021

Conversation

kamranayub
Copy link
Member

@kamranayub kamranayub commented Dec 18, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

I think this may fix the issue with site builds, since TSC will no longer reference types it doesn't need to care about. This also slightly improves TSC build time by 3-4s.

node_modules/.bin/tsc --project src/engine/tsconfig.json --extendedDiagnostics
incremental: false
tsBuildInfoFile: removed

Before

Files:                         382
Lines of Library:            26543
Lines of Definitions:        89293
Lines of TypeScript:         34370
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Nodes of Library:           114498
Nodes of Definitions:       213466
Nodes of TypeScript:        146414
Nodes of JavaScript:             0
Nodes of JSON:                   0
Nodes of Other:                  0
Identifiers:                158190
Symbols:                    159722
Types:                       50704
Instantiations:             107280
Memory used:               271671K
Assignability cache size:    12233
Identity cache size:           217
Subtype cache size:            565
Strict subtype cache size:      51
I/O Read time:               0.15s
Parse time:                  2.10s
ResolveModule time:          0.36s
ResolveTypeReference time:   0.08s
Program time:                2.98s
Bind time:                   1.11s
Check time:                  7.38s
transformTime time:          1.19s
Source Map time:             0.18s
commentTime time:            0.31s
I/O Write time:              0.43s
printTime time:              4.28s
Emit time:                   4.28s
Total time:                 15.75s

After

Files:                         236
Lines of Library:            24957
Lines of Definitions:           41
Lines of TypeScript:         34370
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Nodes of Library:           111131
Nodes of Definitions:           96
Nodes of TypeScript:        146413
Nodes of JavaScript:             0
Nodes of JSON:                   0
Nodes of Other:                  0
Identifiers:                 88504
Symbols:                     55803
Types:                       19136
Instantiations:              10316
Memory used:               164567K
Assignability cache size:     6076
Identity cache size:           111
Subtype cache size:            563
Strict subtype cache size:      51
I/O Read time:               0.10s
Parse time:                  1.49s
ResolveModule time:          0.16s
Program time:                1.91s
Bind time:                   0.76s
Check time:                  4.89s
transformTime time:          1.24s
Source Map time:             0.18s
commentTime time:            0.30s
I/O Write time:              0.44s
printTime time:              4.36s
Emit time:                   4.36s
Total time:                 11.92s

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Dec 18, 2021
src/engine/tsconfig.json Outdated Show resolved Hide resolved
@kamranayub kamranayub merged commit 37a67ca into main Dec 18, 2021
@kamranayub kamranayub deleted the fix/types-restrict branch December 18, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants