Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Arcade Solver Jitter on stacked/overlapped tiles #2104

Merged
merged 6 commits into from
Nov 13, 2021

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Nov 12, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Fixes an issue where overlapping tiles would cause a jitter, due to the arcade solver double solving the same mtv

Changes:

  • Check if contact overlaps before solving position

Before

jitter

After

no-jitter

@eonarheim eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Nov 12, 2021
@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Nov 12, 2021
@eonarheim eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label Nov 12, 2021
eonarheim added a commit to excaliburjs/excalibur-tiled that referenced this pull request Nov 12, 2021
…lemap layer

When fixing excaliburjs/Excalibur#2104 we discovered that there were inadvertently extra colliders being generated which adds some extra overhead to the collision system. This tweak only applies solid TileMap tiles that map to the specific raw layer with the solid property.
@eonarheim eonarheim merged commit edc22e2 into main Nov 13, 2021
@eonarheim eonarheim deleted the fix/reduce-arcade-solver-jitter branch November 13, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant