Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Tslint documentation rule #1267

Closed
wants to merge 2 commits into from
Closed

Enable Tslint documentation rule #1267

wants to merge 2 commits into from

Conversation

chris-bingham
Copy link

Changes

  • Add documentation linting to tslint/tslint.json
  • Set "severity": "warn"

Closes #395

@kamranayub kamranayub added chore Maintenance tasks, like upgrading libraries or release tasks tools labels Nov 24, 2019
kamranayub
kamranayub approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@kamranayub kamranayub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of new warnings but it looks like they are all correctly identifying public symbols

@eonarheim
Copy link
Member

Closing for now, will re-open on eslint changes noted in #395

@eonarheim eonarheim closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamranayub kamranayub kamranayub approved these changes

Assignees

@eonarheim eonarheim

Labels
chore Maintenance tasks, like upgrading libraries or release tasks tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable eslint rule equivalent to ts-lint completed-docs rule
4 participants
@chris-bingham @eonarheim @kamranayub @jedeen