Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSLint is deprecated switch to ESLint #1212

Closed
eonarheim opened this issue Jul 22, 2019 · 0 comments · Fixed by #1217
Closed

TSLint is deprecated switch to ESLint #1212

eonarheim opened this issue Jul 22, 2019 · 0 comments · Fixed by #1217
Labels
core team This issue should be done by an Excalibur core member tools
Milestone
0.24.0 Release

Comments

@eonarheim
Copy link
Member

Context

TSLint is being deprecated in favor of ESLint, Excalibur should switch over

https://medium.com/palantir/tslint-in-2019-1a144c2317a9
microsoft/TypeScript#29288

Proposal

Switch Excalibur over to using an near equivalent ESLint ruleset to the existing TSLint ruleset

Possibly make use of existing migration guides and tools
@eonarheim eonarheim mentioned this issue Jul 22, 2019
Open
55 tasks
@eonarheim eonarheim added core team This issue should be done by an Excalibur core member tools labels Jul 22, 2019
@eonarheim
Copy link
Member Author

Output from running the conversion tool

C:\Users\Erik\Projects\Excalibur [73.89°F | few clouds] [feature/1212-tslint-to-eslint +0 ~2 -0 !]> npx tslint-to-eslint-config
npx: installed 39 in 10.269s
✨ 19 rules replaced with their ESLint equivalents. ✨
️👀 18 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀
✅ All is well! ✅

@eonarheim eonarheim mentioned this issue Jul 25, 2019
Merged
5 tasks
eonarheim added a commit that referenced this issue Oct 7, 2019
@eonarheim
[#1212] Switch TSlint to ESlint (#1217)
0c01406 
Closes #1212

## Changes:

- Update source where needed with new eslint rules
- Add eslint config + dependencies
- Update build process to use eslint
@jedeen jedeen added this to the 0.24.0 Release milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core team This issue should be done by an Excalibur core member tools
Projects
None yet
Milestone
0.24.0 Release
Development

Successfully merging a pull request may close this issue.

[#1212] Switch TSlint to ESlint excaliburjs/Excalibur
2 participants
@eonarheim @jedeen