#519: Add configuration for step customization #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
reviewed
Apr 3, 2024
ckunki
requested changes
Apr 3, 2024
project-keeper/src/main/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReader.java
Show resolved
Hide resolved
...l-classes/src/main/java/com/exasol/projectkeeper/shared/config/workflow/WorkflowOptions.java
Outdated
Show resolved
Hide resolved
...l-classes/src/main/java/com/exasol/projectkeeper/shared/config/workflow/WorkflowOptions.java
Outdated
Show resolved
Hide resolved
project-keeper/src/main/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReader.java
Show resolved
Hide resolved
| /** Insert the step after the configured step ID. */ | ||
| INSERT_AFTER, | ||
| /** Replace the step with the new one. */ | ||
| REPLACE |
There was a problem hiding this comment.
Could there also be INSERT_BEFORE and DELETE?
There was a problem hiding this comment.
Yes, that's possible. But I don't think we need it at the moment.
project-keeper/src/test/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReaderTest.java
Outdated
Show resolved
Hide resolved
project-keeper/src/test/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReaderTest.java
Outdated
Show resolved
Hide resolved
project-keeper/src/test/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReaderTest.java
Outdated
Show resolved
Hide resolved
project-keeper/src/test/java/com/exasol/projectkeeper/config/ProjectKeeperConfigReaderTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| private final Map<String, Object> rawStep; | ||
|
|
||
| private WorkflowStep(final Map<String, Object> rawStep) { |
There was a problem hiding this comment.
Is there a specific reason for the constructor being private and offering a static method for instantiation?
There was a problem hiding this comment.
We might want to add some validation in the future.
ckunki
reviewed
Apr 3, 2024
ckunki
approved these changes
Apr 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #519