Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#338 Generate ci script #339

Merged
merged 12 commits into from
Aug 5, 2022
Merged

#338 Generate ci script #339

merged 12 commits into from
Aug 5, 2022

Conversation

kaklakariada
Copy link
Collaborator

Closes #338

@kaklakariada kaklakariada changed the title #338 enerate ci script #338 Generate ci script Aug 4, 2022
ckunki
ckunki requested changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@ckunki ckunki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor proposal / questions regarding wording and logic.
the "templates/" prefix is still unclear to me.
Happy to talk about it 😄

doc/changes/changes_2.5.1.md Outdated Show resolved Hide resolved
project-keeper/pom.xml Show resolved Hide resolved
project-keeper/src/main/java/com/exasol/projectkeeper/ProjectKeeper.java Show resolved Hide resolved
...keeper/src/main/java/com/exasol/projectkeeper/validators/files/FileTemplateFromResource.java Outdated Show resolved Hide resolved
...ect-keeper/src/main/java/com/exasol/projectkeeper/validators/files/FileTemplatesFactory.java Show resolved Hide resolved
...ct-keeper/src/main/java/com/exasol/projectkeeper/validators/files/ProjectFilesValidator.java Show resolved Hide resolved
...ect-keeper/src/main/java/com/exasol/projectkeeper/validators/files/FileTemplatesFactory.java Show resolved Hide resolved
project-keeper/src/main/resources/non_maven_templates/.github/workflows/project-keeper.sh Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.9% 80.9% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada merged commit 3f5b84b into main Aug 5, 2022
@kaklakariada kaklakariada deleted the #338-generate-ci-script branch August 5, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckunki ckunki ckunki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate script for running PK in CI
2 participants
@kaklakariada @ckunki