Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running with multiple Maven versions #585

Closed
kaklakariada opened this issue Sep 11, 2024 · 0 comments · Fixed by #590
Closed

Support running with multiple Maven versions #585

kaklakariada opened this issue Sep 11, 2024 · 0 comments · Fixed by #590
Assignees
Labels
feature Product feature

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented Sep 11, 2024

The list of plugins generated in the changelog file and dependencies.md depends on the Maven version that is used for running PK fix / PK verify. Plugins not explicitly specified in the (parent) POM are used in the default versions specific to the Maven version. This leads to different versions depending on the Maven version.

Affected are the following plugins included by default. Maven 3.8.7 uses the following versions:

* Added `org.apache.maven.plugins:maven-clean-plugin:2.5`
* Added `org.apache.maven.plugins:maven-dependency-plugin:2.8`
* Added `org.apache.maven.plugins:maven-deploy-plugin:2.7`
* Added `org.apache.maven.plugins:maven-install-plugin:2.4`
* Added `org.apache.maven.plugins:maven-jar-plugin:2.4`
* Added `org.apache.maven.plugins:maven-resources-plugin:2.6`
* Added `org.apache.maven.plugins:maven-site-plugin:3.3`

Maven 3.9.9 uses these versions:

* Added `org.apache.maven.plugins:maven-clean-plugin:3.2.0`
* Added `org.apache.maven.plugins:maven-dependency-plugin:3.7.0`
* Added `org.apache.maven.plugins:maven-deploy-plugin:3.1.2`
* Added `org.apache.maven.plugins:maven-install-plugin:3.1.2`
* Added `org.apache.maven.plugins:maven-jar-plugin:3.4.1`
* Added `org.apache.maven.plugins:maven-resources-plugin:3.3.1`
* Added `org.apache.maven.plugins:maven-site-plugin:3.12.1`

Proposed solution:

PK should explicitly add these plugins with up-to-date versions and without configuration to the parent pom.

Workaround

Use Maven 3.8.x locally, don't upgrade to 3.9.x

@kaklakariada kaklakariada added the feature Product feature label Sep 11, 2024
@kaklakariada kaklakariada self-assigned this Oct 21, 2024
kaklakariada added a commit that referenced this issue Oct 21, 2024
kaklakariada added a commit that referenced this issue Oct 21, 2024
kaklakariada added a commit that referenced this issue Oct 21, 2024
kaklakariada added a commit that referenced this issue Oct 21, 2024
* Fix user guide URL

* Update eclipse jdt config for new eclipse version

* Upgrade Maven plugins

* #585: Pin plugin versions

* Run PK fix

* #585: Adapt unit test

* Upgrade dependencies

* Mark eclipse config files as generated

* #585: Adapt integration test

* Update eclipse config files for latest version

* Fix dependencies
kaklakariada added a commit that referenced this issue Oct 23, 2024
* Fix user guide URL

* Update eclipse jdt config for new eclipse version

* Upgrade Maven plugins

* #585: Pin plugin versions

* Run PK fix

* #585: Adapt unit test

* Upgrade dependencies

* Mark eclipse config files as generated

* #585: Adapt integration test

* Update eclipse config files for latest version

* Fix dependencies

* #585: Add quality-summarizer-maven-plugin

* Fix review findings from other PRs

* Run PK fix

* Add coverage aggregator module

* Disable eclipse compiler flag --release

* Archive metrics.json

* Add changelog entry

* Upgrade to quality metrics plugin 0.2.0

* Verify that build created the metrics.json file

* Increment minor version

* Update release date

* Update doc/changes/changes_4.4.0.md

Co-authored-by: Sebastian Bär <[email protected]>

---------

Co-authored-by: Sebastian Bär <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant