Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks don't run for dependency update PR #534

Closed
2 tasks done
kaklakariada opened this issue Feb 27, 2024 · 1 comment · Fixed by #535
Closed
2 tasks done

Checks don't run for dependency update PR #534

kaklakariada opened this issue Feb 27, 2024 · 1 comment · Fixed by #535
Assignees
@kaklakariada
Labels
feature Product feature

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented Feb 27, 2024 •
edited
Loading

When the dependency update workflow (#515) creates a PR with dependency updates, the checks for this PR don't run initially.

Possible options:

  1. User closes and re-opens the PR to trigger the checks
  2. The workflow uses a PAT (personal access token) or GitHub App token to create the PR

See

We decided to implement option 1 for now because it has less impact, and the inconvenience for the user is acceptable.

AC

  • Decision and alternatives documented in design
  • A comment in the created PR asks the user to close & reopen the PR
@kaklakariada kaklakariada added the feature Product feature label Feb 27, 2024
@kaklakariada kaklakariada self-assigned this Feb 27, 2024
kaklakariada added a commit that referenced this issue Feb 28, 2024
@kaklakariada
#534 Add note to PR for triggering PR checks
0921828
@kaklakariada kaklakariada mentioned this issue Feb 28, 2024
Merged
@kaklakariada
Copy link
Collaborator Author

Effort: ~0.5pd

kaklakariada added a commit that referenced this issue Feb 28, 2024
@kaklakariada
#534 Trigger CI build for PR (#535)
6bc1669
@pj-spoelders pj-spoelders changed the title Checks don't run for depedency update PR Checks don't run for dependency update PR Mar 1, 2024
This was referenced Mar 19, 2024
Closed
Closed
Closed
This was referenced Mar 27, 2024
Closed
Closed
Merged
This was referenced Apr 10, 2024
Closed
Merged
Closed
Closed
Closed
Closed
@github-actions github-actions bot mentioned this issue May 9, 2024
Closed
@github-actions github-actions bot mentioned this issue May 30, 2024
Closed
This was referenced Jul 25, 2024
Closed
Open
Closed
Open
This was referenced Sep 21, 2024
Open
Closed
Closed
Merged
This was referenced Sep 28, 2024
Open
Closed
Open
This was referenced Oct 5, 2024
Closed
Open
Closed
Open
Closed
Open
Open
Open
Closed
This was referenced Oct 16, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#534 Trigger CI build for PR exasol/project-keeper
1 participant
@kaklakariada