Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java.version property from parent pom if available #530

Closed
kaklakariada opened this issue Feb 22, 2024 · 0 comments · Fixed by #593
Closed

Use java.version property from parent pom if available #530

kaklakariada opened this issue Feb 22, 2024 · 0 comments · Fixed by #593
Assignees
@kaklakariada
Labels
feature Product feature

Comments

@kaklakariada
Copy link
Collaborator

PK generates property java.version with hard coded value 11 in pk_generated_parent.pom. This can be overridden in pom.xml to 17 if necessary.

However in multi-module projects this will always override java.version to 11, even if all modules should use 17. Thus it would be better to not add property java.version when there is a custom parent pom (parameter parentPom: in .project-keeper.yml).

Relevant method: PomFileGenerator.properties().
@kaklakariada kaklakariada added the feature Product feature label Feb 22, 2024
@kaklakariada kaklakariada self-assigned this Oct 21, 2024
kaklakariada added a commit that referenced this issue Oct 21, 2024
@kaklakariada
#530: Use java.version property from parent pom if available
1e24d28
@kaklakariada kaklakariada mentioned this issue Oct 21, 2024
Merged
kaklakariada added a commit that referenced this issue Oct 22, 2024
@kaklakariada
#530: Use java.version property from parent pom if available (#593)
d187472 
* #530: Use `java.version` property from parent pom if available

* Fix sonar warning

* Implement review finding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#530: Use java.version property from parent pom if available exasol/project-keeper
1 participant
@kaklakariada