Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go dependencies #331

Closed
ckunki opened this issue Aug 1, 2022 · 1 comment · Fixed by #335
Closed

Fix Go dependencies #331

ckunki opened this issue Aug 1, 2022 · 1 comment · Fixed by #335
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@ckunki
Copy link
Collaborator

ckunki commented Aug 1, 2022

Currently project-keeper's java class GolangServices uses

go list -f "{{if not .Indirect}}{{.}}{{end}}" -m all

and applies go-licenses csv to each entry.

This fails for repository project-overview, which currently has dependencies to

To fix project-keeper go list needs to be called like this:

go list -f "{{if .Module}}{{if not .Module.Indirect}}{{.ImportPath}} {{.Module.Version}}{{end}}{{end}}" all

See also https://pkg.go.dev/cmd/go#hdr-List_packages_or_modules

@ckunki ckunki added the bug Unwanted / harmful behavior label Aug 1, 2022
@ckunki
Copy link
Collaborator Author

ckunki commented Aug 1, 2022

Observation: proposed solution tends to list too many modules.

@kaklakariada kaklakariada self-assigned this Aug 3, 2022
kaklakariada added a commit that referenced this issue Aug 3, 2022
kaklakariada added a commit that referenced this issue Aug 4, 2022
* #331: Accept module prefix for matching license

* #331 Fixed retrieving Golang dependencies

Co-authored-by: Thomas Ubensee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants