Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the reproducible-build-maven-plugin is the last plugin in the plugins list #132

Closed
AnastasiiaSergienko opened this issue Jun 2, 2021 · 1 comment · Fixed by #337
Assignees
Labels
feature Product feature

Comments

@AnastasiiaSergienko
Copy link
Contributor

AnastasiiaSergienko commented Jun 2, 2021

Problem

Maven plugins that belong to the same execution phase are executed in the order they are places in the pom file. The problem here is if we place the source plugin after the reproducible-build-maven-plugin, the source jar is not stripped because it's generated after the reproducible-build-maven-plugin runs.

Possible Solution

Validate that the reproducible-build-maven-plugin is the last plugin in the plugins list.

@jakobbraun
Copy link
Contributor

I don't really like to have the rule that it must be the last plugin in the list, since:

  • It's a too hard criteria – It will produce validation findings even though everything is ok
  • It's critical if we have more plugins that need to be the last one

Ideas:

  • Add a weight for different plugins: For plugins with same order, weight is irrelevant
  • Only validate weight in the scope of execution phase

On the other hand, maybe it would make sense to order our plugins by execution phase...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants