fix: emit rows affected attribute #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obitech
reviewed
May 16, 2024
Before this commit the `pgx.rows_affected` attribute would only be emitted in case of error. The commit flips the check such that we emit it when an error has not occurred.
nordfjord
force-pushed
the
fix/rows-affected
branch
from
4c5648c to
a86006f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the
pgx.rows_affectedattribute would only beemitted in case of error. The commit flips the check such that we emit
it when an error has not occurred.
Though I wonder if it's safe to remove the check wholesale