Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(esl-core): make this.constructor strictly typed for ESLBaseElement and ESLMixinElement #1536

Merged
merged 3 commits into from
Mar 13, 2023
Merged

feat(esl-core): make this.constructor strictly typed for ESLBaseElement and ESLMixinElement #1536

merged 3 commits into from
Mar 13, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Mar 10, 2023

No description provided.

@ala-n ala-n requested a review from a team March 10, 2023 00:54
@ala-n ala-n self-assigned this Mar 10, 2023
@ala-n ala-n requested review from dshovchko, julia-murashko and yadamskaya and removed request for a team March 10, 2023 00:54
@ala-n ala-n added needs review The PR is waiting for review and removed under discussion labels Mar 10, 2023
@ala-n ala-n added this to the ⚡ESL: 4.4.0 Minor release milestone Mar 10, 2023
@ala-n ala-n mentioned this pull request Mar 10, 2023
Closed
@codeclimate
Copy link

codeclimate bot commented Mar 13, 2023

Code Climate has analyzed commit 87524f0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.3% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit f840fbe into main Mar 13, 2023
@ala-n ala-n deleted the feat/constructor-type-proposal branch March 13, 2023 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2023
@ala-n ala-n linked an issue Mar 14, 2023 that may be closed by this pull request
feat(esl-core): shortcut method to access typed this.constructor or at least it's tag #1520
Closed
@ala-n
Copy link
Collaborator Author

ala-n commented Mar 17, 2023

Reverted due to TS issue with Partial of hacked object
Hacks with generic functions also do not work due to TS not resolving instance type deeper than the default definition.
So according to microsoft/TypeScript#3841 (comment)
unfortunately, we have no more legal options to make it strictly typed as expected.
The shortcut for tagName is implemented in #1551, and that's all until a fix from TS appears (if it appears).

@ala-n
Copy link
Collaborator Author

ala-n commented Apr 12, 2023

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NastaLeo NastaLeo NastaLeo approved these changes

@fshovchko fshovchko fshovchko approved these changes

@abarmina abarmina abarmina approved these changes

@dshovchko dshovchko dshovchko approved these changes

@julia-murashko julia-murashko Awaiting requested review from julia-murashko julia-murashko was automatically assigned from exadel-inc/esl-core-team

@yadamskaya yadamskaya Awaiting requested review from yadamskaya yadamskaya was automatically assigned from exadel-inc/esl-core-team

Assignees

@ala-n ala-n

Labels
needs review The PR is waiting for review released
Projects
None yet
Milestone
⚡ESL: 4.4.0 Minor release
Development

Successfully merging this pull request may close these issues.

feat(esl-core): shortcut method to access typed this.constructor or at least it's tag
5 participants
@ala-n @dshovchko @abarmina @fshovchko @NastaLeo