Skip to content

Commit

Permalink
Merge pull request #3 from ewrogers/code-standards
Browse files Browse the repository at this point in the history 
Code standards
  • Loading branch information
@ewrogers
ewrogers authored Apr 9, 2023
2 parents 4e54f0b + 9304160 commit 4691428
Show file tree
Hide file tree
Showing 151 changed files with 15,536 additions and 15,410 deletions.
126 changes: 126 additions & 0 deletions .editorconfig
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
###############################
# Core EditorConfig Options #
###############################
root = true
# All files
[*]
indent_style = space

# XML project files
[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]
indent_size = 2

# XML config files
[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct}]
indent_size = 2

# Code files
[*.{cs,csx,vb,vbx}]
indent_size = 4
insert_final_newline = true
charset = utf-8-bom
###############################
# .NET Coding Conventions #
###############################
[*.{cs,vb}]
# Organize usings
dotnet_sort_system_directives_first = true
# this. preferences
dotnet_style_qualification_for_field = false:silent
dotnet_style_qualification_for_property = false:silent
dotnet_style_qualification_for_method = false:silent
dotnet_style_qualification_for_event = false:silent
# Language keywords vs BCL types preferences
dotnet_style_predefined_type_for_locals_parameters_members = true:silent
dotnet_style_predefined_type_for_member_access = true:silent
# Parentheses preferences
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
# Modifier preferences
dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
dotnet_style_readonly_field = true:suggestion
# Expression-level preferences
dotnet_style_object_initializer = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_null_propagation = true:suggestion
dotnet_style_coalesce_expression = true:suggestion
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent
dotnet_style_prefer_inferred_tuple_names = true:suggestion
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
dotnet_style_prefer_auto_properties = true:silent
dotnet_style_prefer_conditional_expression_over_assignment = true:silent
dotnet_style_prefer_conditional_expression_over_return = true:silent
###############################
# Naming Conventions #
###############################
# Style Definitions
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
# Use PascalCase for constant fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
dotnet_naming_symbols.constant_fields.required_modifiers = const
###############################
# C# Coding Conventions #
###############################
[*.cs]
# var preferences
csharp_style_var_for_built_in_types = true:silent
csharp_style_var_when_type_is_apparent = true:silent
csharp_style_var_elsewhere = true:silent
# Expression-bodied members
csharp_style_expression_bodied_methods = false:silent
csharp_style_expression_bodied_constructors = false:silent
csharp_style_expression_bodied_operators = false:silent
csharp_style_expression_bodied_properties = true:silent
csharp_style_expression_bodied_indexers = true:silent
csharp_style_expression_bodied_accessors = true:silent
# Pattern matching preferences
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
# Null-checking preferences
csharp_style_throw_expression = true:suggestion
csharp_style_conditional_delegate_call = true:suggestion
# Modifier preferences
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
# Expression-level preferences
csharp_prefer_braces = true:silent
csharp_style_deconstructed_variable_declaration = true:suggestion
csharp_prefer_simple_default_expression = true:suggestion
csharp_style_prefer_local_over_anonymous_function = true:suggestion
csharp_style_inlined_variable_declaration = true:suggestion
###############################
# C# Formatting Rules #
###############################
# New line preferences
csharp_new_line_before_open_brace = all
csharp_new_line_before_else = true
csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_between_query_expression_clauses = true
# Indentation preferences
csharp_indent_case_contents = true
csharp_indent_switch_labels = true
csharp_indent_labels = flush_left
# Space preferences
csharp_space_after_cast = false
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_parentheses = false
csharp_space_before_colon_in_inheritance_clause = true
csharp_space_after_colon_in_inheritance_clause = true
csharp_space_around_binary_operators = before_and_after
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
csharp_space_between_method_call_name_and_opening_parenthesis = false
csharp_space_between_method_call_empty_parameter_list_parentheses = false
# Wrapping preferences
csharp_preserve_single_line_statements = true
csharp_preserve_single_line_blocks = true
4 changes: 2 additions & 2 deletions SleepHunter/App.xaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<ResourceDictionary Source="Templates\ClientVersionDataTemplate.xaml"/>
<ResourceDictionary Source="Templates\ColorThemeDataTemplate.xaml"/>
<ResourceDictionary Source="Templates\MetadataDataTemplates.xaml"/>
<ResourceDictionary Source="Templates\PlayerDataTemplate.xaml"/>
<ResourceDictionary Source="Templates\SpellTargetDataTemplates.xaml"/>
<ResourceDictionary Source="Templates\PlayerDataTemplate.xaml"/>
<ResourceDictionary Source="Templates\SpellTargetDataTemplates.xaml"/>
</ResourceDictionary.MergedDictionaries>
</ResourceDictionary>
</Application.Resources>
Expand Down
6 changes: 3 additions & 3 deletions SleepHunter/App.xaml.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace SleepHunter
{
public partial class App : Application
{
}
public partial class App : Application
{
}
}
112 changes: 56 additions & 56 deletions SleepHunter/Commands/AsyncDelegateCommand.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,71 +4,71 @@

namespace SleepHunter.Commands
{
public class AsyncDelegateCommand : AsyncDelegateCommand<object>, IAsyncCommand
{
public AsyncDelegateCommand(Func<Task> onExecute, Func<bool> onCanExecute = null)
: base(o => onExecute?.Invoke(), o => onCanExecute != null ? onCanExecute() : true)
public class AsyncDelegateCommand : AsyncDelegateCommand<object>, IAsyncCommand
{
if (onExecute == null)
throw new ArgumentNullException(nameof(onExecute));
public AsyncDelegateCommand(Func<Task> onExecute, Func<bool> onCanExecute = null)
: base(o => onExecute?.Invoke(), o => onCanExecute != null ? onCanExecute() : true)
{
if (onExecute == null)
throw new ArgumentNullException(nameof(onExecute));
}
}
}

public class AsyncDelegateCommand<T> : IAsyncCommand<T>, ICommand
{
readonly Func<T, Task> onExecute;
readonly DelegateCommand<T> underlyingCommand;
bool isExecuting;

public event EventHandler CanExecuteChanged
public class AsyncDelegateCommand<T> : IAsyncCommand<T>, ICommand
{
add { underlyingCommand.CanExecuteChanged += value; }
remove { underlyingCommand.CanExecuteChanged -= value; }
}
readonly Func<T, Task> onExecute;
readonly DelegateCommand<T> underlyingCommand;
bool isExecuting;

public AsyncDelegateCommand(Func<T, Task> onExecute, Func<T, bool> onCanExecute = null)
{
if (onExecute == null)
throw new ArgumentNullException(nameof(onExecute));
public event EventHandler CanExecuteChanged
{
add { underlyingCommand.CanExecuteChanged += value; }
remove { underlyingCommand.CanExecuteChanged -= value; }
}

this.onExecute = onExecute;
underlyingCommand = new DelegateCommand<T>(x => { }, onCanExecute);
}
public AsyncDelegateCommand(Func<T, Task> onExecute, Func<T, bool> onCanExecute = null)
{
if (onExecute == null)
throw new ArgumentNullException(nameof(onExecute));

#region ICommand Methods
public async void Execute(object parameter)
{
await ExecuteAsync((T)parameter);
}
this.onExecute = onExecute;
underlyingCommand = new DelegateCommand<T>(x => { }, onCanExecute);
}

public bool CanExecute(object parameter)
{
return !isExecuting && underlyingCommand.CanExecute((T)parameter);
}
#endregion
#region ICommand Methods
public async void Execute(object parameter)
{
await ExecuteAsync((T)parameter);
}

#region IAsyncCommand<T> Methods
public async Task ExecuteAsync(T parameter)
{
try
{
isExecuting = true;
RaiseCanExecuteChanged();
await onExecute(parameter);
}
finally
{
isExecuting = false;
RaiseCanExecuteChanged();
}
}
#endregion
public bool CanExecute(object parameter)
{
return !isExecuting && underlyingCommand.CanExecute((T)parameter);
}
#endregion

#region IRaiseCanExecuteChanged Methods
public void RaiseCanExecuteChanged()
{
underlyingCommand.RaiseCanExecuteChanged();
#region IAsyncCommand<T> Methods
public async Task ExecuteAsync(T parameter)
{
try
{
isExecuting = true;
RaiseCanExecuteChanged();
await onExecute(parameter);
}
finally
{
isExecuting = false;
RaiseCanExecuteChanged();
}
}
#endregion

#region IRaiseCanExecuteChanged Methods
public void RaiseCanExecuteChanged()
{
underlyingCommand.RaiseCanExecuteChanged();
}
#endregion
}
#endregion
}
}
Loading

0 comments on commit 4691428

Please sign in to comment.