Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footnote for crosstable (summary_factorlist) showing hypothesis test names of corresponding p-values #52

Closed
sbalci opened this issue Jun 18, 2020 · 4 comments

Comments

@sbalci
Copy link

sbalci commented Jun 18, 2020

Dear developers,

I went through the code but could not find an option for this.

It would be nice to have hypothesis test names of corresponding p-values as a footnote when using summary_factorlist.

Best wishes.

@ewenharrison
Copy link
Owner

Thanks Serdar.
As you know, we have kept all tables as data frames or tibbles in finalfit to be as flexible as possible in output. The question would be how to do that and stay so flexible (one of the benefits of finalfit in my humble opinion!). finalfit(..., metrics = TRUE) has a second data frame with model information and the two are returned as a list. But even this creates an extra step for users separating them.
Interested in your thoughts.

@sbalci
Copy link
Author

sbalci commented Jun 19, 2020

Hi Ewen,

I continue to try to add some functions to jamovi as a module. While working on crosstables I wanted to compare some similar packages. I added tangram, arsenal, gtsummary and finalfit. Then I realised that the p-values are different. See below images.

FinalFit:
finalfit

gtsummary:
gtsummary

tangram:
(is currently under update in with recent commit p-values are gone, probably will be fixed soon)
tangram

arsenal:
arsenal

The problem is that users are ready to accept these results as publication ready and I wanted to add the test names. I think the packages use different tests and I tried to dig into codes. tangram (as default and text), arsenal as an argument, and gtsummary as an optional function gives the names of functions. I could not add arsenal's test names due to html output structure (mayoverse/arsenal#298).

  • For the metrics = TRUE I tried to add it to multivariate survival function, the output is skewed, but it can be worked on.

Ekran Resmi 2020-06-19 17 29 21

  • If the output is a list and I can extract them as result[["table"]] and results[["footnote"]] it will be easy to implement.

  • Or, to keep dataframe output, you may consider adding another column for test names and include it optional argument similar to p = TRUE something like testname = TRUE. This way you may get rid of pasting asteriks, symbols or numbers to p-value. And with another function footnote can be generated via combining variable name and testname from dataframe output.

Thank you for your time.

@ewenharrison
Copy link
Owner

Thanks. There is a choice of tests with summary_factorlist that can be specified. So it kind of depends what the user wants to do. Are you utilising the various column and row summarising arguments? Let me know if anything is not clear in the documentation and I can adjust.

@sbalci
Copy link
Author

sbalci commented Jun 19, 2020

Then I can add the arguments as options to the user interface and depending on the selected one I can add test names and I can add a link to the documentation

cont = "mean", cont_nonpara = NULL, p_cont_para = "aov", p_cat = "chisq"

Thank you :) I will let you know the updates.

sbalci added a commit to sbalci/ClinicoPathJamoviModule that referenced this issue Jun 28, 2020
- Added tangram statistical results
- Added options to finalfit crosstables
fixes: #24
fixes: jamovi/jamovi#901
fixes: ewenharrison/finalfit#52

- Added experimental biblometrics functions
- includes experimental changes
@sbalci sbalci closed this as completed Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants