Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the DOI exports #2058

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fixed the DOI exports #2058

merged 3 commits into from
Sep 21, 2023

Conversation

vladsavelyev
Copy link
Member

Add missing modules_output parameter.

@vladsavelyev vladsavelyev added the bug: core Bug in the main MultiQC code label Sep 20, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.16 milestone Sep 20, 2023
ewels
ewels approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!

@ewels
Copy link
Member

ewels commented Sep 21, 2023

Changelog!

@vladsavelyev vladsavelyev changed the title Fix dois_tofile Fixed the DOI exports Sep 21, 2023
@vladsavelyev vladsavelyev merged commit e407686 into master Sep 21, 2023
10 checks passed
@ewels ewels deleted the fix-doi-to-files branch September 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
bug: core Bug in the main MultiQC code
Projects
None yet
Milestone
v1.16: Software Versions
Development

Successfully merging this pull request may close these issues.
2 participants
@vladsavelyev @ewels