This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Adds support for Byzantium opcodes (WIP) #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
changed the title
lrettig
force-pushed
the
byzantium-opcodes
branch
from
529b96a
to
51c61f5
Compare
axic
reviewed
Mar 19, 2018
wasm/generateInterface.js
Outdated
| }, | ||
| RETURNDATASIZE: { | ||
| name: 'getReturnDataSize', | ||
| async: true, |
axic
reviewed
Mar 19, 2018
opcodes.js
Outdated
| @@ -147,6 +149,8 @@ const codes = { | |||
| 0xf2: ['CALLCODE', 0, 7, 1], | |||
| 0xf3: ['RETURN', 0, 2, 0], | |||
| 0xf4: ['DELEGATECALL', 0, 6, 1], | |||
| 0xfa: ['STATICCALL', 0, 6, 1], | |||
| 0xfd: ['REVERT', 0, 2, 0], | |||
|
|
|||
There was a problem hiding this comment.
Should also explicitly handle 0xfe (INVALID), for clarity.
lrettig
force-pushed
the
byzantium-opcodes
branch
from
51c61f5
to
37df757
Compare
axic
force-pushed
the
byzantium-opcodes
branch
2 times, most recently
from
fe9ad80
to
16caec9
Compare
|
Even though this is not finished (not testing the additions), it is still better to merge them as the rest of evm2wasm is broken anyway. |
|
I'm going to start working on this, if that's alright. I talked to @lrettig about it in the Gitter. |
|
It's been merged. Let me know if you find anything missing; and as @axic indicated there are no tests for the new stuff, so that may be a good place to start. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a PR to track this work in progress. Closes #163.