Documentation: translate setup.sh and PULL_REQUEST_TEMPLATE.md #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yafesdot
changed the title
cagrimertbakirci
added
the
documentation
cagrimertbakirci
requested changes
Jan 31, 2022
There was a problem hiding this comment.
Explanation
Related Issue: #
Change Category:
- Bug Fix
- Feature
- Documentation
Aditional Information:
How to Test?
Checklist:
- My code complies with this project's code formatting guidelines.
- I reviewed my code.
- I added comments especially in portions that may be difficult to understand.
- If necessary, I updated the documentation.
- Changes I made do not produce new issues.
- I added or updated tests based on my changes.
- If any, all changes related to my changes are already present in the main branch.
|
Great job, thanks! I wanted to make minor changes to the code, but the "comment" portions of my review seems to have been left out in the above comment. Please compare only the titles and checklists for my corrections and resend. |
|
@cagrimertbakirci, before closing this PR, state your corrections about the comment portions if you want to so I can correct them as well. |
|
@might4 Oh no, there were no corrections in the comment portions. It just didn't bring them in here (which were left as is anyway). So it's ready to go. :) |
cagrimertbakirci
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
I just translated Setup.sh and PULL_REQUEST_TEMPLATE.md
Related Issues: #72 #74
Category of Thing You Changed: