Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python solutions added #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

python solutions added #1

wants to merge 2 commits into from

Conversation

omerahat
Copy link

No description provided.

evrentan
evrentan requested changes Jul 14, 2023
View reviewed changes
Copy link
Owner

@evrentan evrentan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omerahat thanks for the PR. That will be really good to have solutions from different stacks.

Can you create a folder each solution under python-solutions and add a QUESTION.md as I did for java ones. That will be make life easier who are checking the solutions.

evrentan
evrentan requested changes Jul 14, 2023
View reviewed changes
Copy link
Owner

@evrentan evrentan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you update the file names according to PascalCase notation? Thanks.

@omerahat
Copy link
Author

I updated. Thanks

@omerahat
Copy link
Author

@evrentan I'm busy for a few days but I'll add it in 1 week. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evrentan evrentan evrentan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerahat @evrentan