Parse all the 256 Elementary Cellular Automata rules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardinot
requested changes
Apr 28, 2019
plugin.cpp
Outdated
| } else if (!left && !center && right) { | ||
| r = m_binrule.at(6) == "1"; | ||
| } else if (!left && !center && !right) { | ||
| r = m_binrule.at(7) == "1"; | ||
| } |
There was a problem hiding this comment.
You could replace all those if-else statements by:
return Value(m_binrule[left*4 + center*2 + right]);There was a problem hiding this comment.
That's really clever and elegant! I wanted to use some sort of hash to access the cell state, but decided against it since I figured it would be an overkill (and an inefficient one at that).
plugin.cpp
Outdated
| @@ -38,6 +38,8 @@ bool CellularAutomata1D::init() | |||
|
|
|||
| // determines which rule to use | |||
| m_rule = attr("rule").toInt(); | |||
| m_binrule = QString::number(m_rule, 2); | |||
| m_binrule.prepend(QString("0").repeated(8 - m_binrule.length())); | |||
There was a problem hiding this comment.
That's an elegant solution using QString 👏
However, I think we should just use a std::bitset here.
m_binrule = std::bitset<8>(attr("rule").toInt());Please, fix the type of m_binrule to std::bitset<8> m_binrule in the plugin.h file. Also, we can now remove the m_rule member.
metadata.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "author": "Ethan Padden and Marcos Cardinot", | |||
There was a problem hiding this comment.
You may want to add your name here 😄
|
Thanks 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding each separate rule, we can simply infer them from the integer's binary representation.