Skip to content

Commit

Permalink
poetry: Add mysqlclient as optional dependency
Browse files Browse the repository at this point in the history
This makes sure that *if* it is manually installed, it is not removed by
`poetry install --no-dev`. This is not currently relevant, since
mysqlclient and its dependencies are not listed as dev packages, so
poetry will already leave them alone, but making this explicit is
probably better.

It might be better to add this as an "extras" dependency, so it can be
installed by `poetry install --extras`, but it seems that that does not
currently work:

python-poetry/poetry#1145
  • Loading branch information
matthijskooijman committed Jun 5, 2020
1 parent cb3e5c0 commit 6645403
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
18 changes: 16 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ django-airplane = "^1.0.0"
django-phonenumber-field = {extras = ["phonenumbers"], version = "^4.0.0"}
django_sendmail_backend = "^0.1.2"
poetry = {version = "^1.0.7", optional = true}
mysqlclient = {version = "^1.4.6", optional = true}

[tool.poetry.dev-dependencies]
flake8 = "*"
Expand Down

0 comments on commit 6645403

Please sign in to comment.