Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: wrong gas limit when adjust base fee #832

Merged
merged 5 commits into from
Jan 3, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Dec 13, 2021

Closes: #823

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

go.mod Outdated Show resolved Hide resolved
@yihuang yihuang changed the title wrong gas limit is wrong when adjust base fee fix: wrong gas limit when adjust base fee Dec 13, 2021
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, we should wait until it's backported to merge tho

@fedekunze fedekunze marked this pull request as draft December 16, 2021 22:25
@yihuang yihuang marked this pull request as ready for review December 20, 2021 07:42
@yihuang
Copy link
Contributor Author

yihuang commented Dec 20, 2021

ACK, we should wait until it's backported to merge tho

it's merged now, although not tagged yet.

@fedekunze fedekunze merged commit 9f4828e into evmos:main Jan 3, 2022
@yihuang yihuang deleted the consensus-params branch January 4, 2022 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: block gas limit is wrong when adjust base fee
2 participants