Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

set debug based on tracer #746

Merged
merged 9 commits into from
Nov 16, 2021
Merged

set debug based on tracer #746

merged 9 commits into from
Nov 16, 2021

Conversation

crypto-facs
Copy link
Contributor

Description

Changed default EVM tracer to nil and setting Evm`s debug mode based on tracer.

This will avoid the printing of unnecessary and expensive trace logs without losing debug_traceTransaction support. This will have a big impact on indexer nodes performances.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@crypto-facs crypto-facs marked this pull request as draft November 15, 2021 03:07
x/evm/keeper/state_transition.go Outdated Show resolved Hide resolved
x/evm/keeper/state_transition.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #746 (b27033e) into main (f42f339) will increase coverage by 0.03%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   55.81%   55.84%   +0.03%     
==========================================
  Files          64       64              
  Lines        5853     5857       +4     
==========================================
+ Hits         3267     3271       +4     
  Misses       2386     2386              
  Partials      200      200              
Impacted Files Coverage Δ
server/config/config.go 21.48% <0.00%> (ø)
x/evm/types/tracer.go 47.36% <33.33%> (+0.93%) ⬆️
app/app.go 83.80% <100.00%> (ø)
x/evm/keeper/grpc_query.go 66.09% <100.00%> (ø)
x/evm/keeper/keeper.go 75.86% <100.00%> (-0.14%) ⬇️
x/evm/keeper/state_transition.go 76.74% <100.00%> (+0.31%) ⬆️

@crypto-facs crypto-facs marked this pull request as ready for review November 15, 2021 23:25
@fedekunze fedekunze enabled auto-merge (squash) November 16, 2021 08:49
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit d4621f3 into evmos:main Nov 16, 2021
thomas-nguy referenced this pull request in crypto-org-chain/ethermint Nov 17, 2021
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:x/evm EVM module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants