This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-facs
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
November 15, 2021 02:51
fedekunze
reviewed
Nov 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 55.81% 55.84% +0.03%
==========================================
Files 64 64
Lines 5853 5857 +4
==========================================
+ Hits 3267 3271 +4
Misses 2386 2386
Partials 200 200
|
fedekunze
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
thomas-nguy
referenced
this pull request
in crypto-org-chain/ethermint
Nov 17, 2021
Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed default EVM tracer to nil and setting Evm`s debug mode based on tracer.
This will avoid the printing of unnecessary and expensive trace logs without losing
debug_traceTransaction
support. This will have a big impact on indexer nodes performances.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)