Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: use global []byte slice to avoid sring -> []byte conversions in loop #595

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Sep 28, 2021

Closes: #573

Description

Instead of doing multiple conversions in the loop, use a global []byte slice of evmtypes.AttributeKeyEthereumBloom.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze merged commit fdb92ee into evmos:main Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants