Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

RPC: Fix TraceConfig parameter for tracers #565

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

crypto-facs
Copy link
Contributor

@crypto-facs crypto-facs commented Sep 15, 2021

Closes: #564

Description

Log Configurations params where not being captured by the TraceConfig param on traceTransaction.

Decided to merge it into one single message for params not to be missed.

Now the endpoint returns as expected:

{"jsonrpc":"2.0","id":1,"result":{"failed":false,"gas":38016,"returnValue":"","structLogs":[{"depth":1,"gas":4501248,"gasCost":3,"op":"PUSH1","pc":0},{"depth":1,"gas":4501245,"gasCost":3,"op":"PUSH1","pc":2},{"depth":1,"gas":4501242,"gasCost":12,"op":"MSTORE","pc":4},{"depth":1,"gas":4501230,"gasCost":2,"op":"CALLDATASIZE","pc":5},{"depth":1,"gas":4501228,"gasCost":3,"op":"PUSH2","pc":6},{"depth":1,"gas":4501225,"gasCost":10,"op":"JUMPI","pc":9},{"depth":1,"gas":4501215,"gasCost":1,"op":"JUMPDEST","pc":19},{"depth":1,"gas":4501214,"gasCost":3,"op":"PUSH2","pc":20},{"depth":1,"gas":4501211,"gasCost":1,"op":"JUMPDEST","pc":23},{"depth":1,"gas":4501210,"gasCost":3,"op":"PUSH2","pc":24},{"depth":1,"gas":4501207,"gasCost":3,"op":"PUSH2","pc":27},{"depth":1,"gas":4501204,"gasCost":3,"op":"PUSH2","pc":30},{"depth":1,"gas":4501201,"gasCost":8,"op":"JUMP","pc":33},{"depth":1,"gas":4501193,"gasCost":1,"op":"JUMPDEST","pc":94},{"depth":1,"gas":4501192,"gasCost":3,"op":"PUSH1","pc":95},{"depth":1,"gas":4501189,"gasCost":3,"op":"PUSH2","pc":97},{"depth":1,"gas":4501186,"gasCost":3,"op":"PUSH32","pc":100},{"depth":1,"gas":4501183,"gasCost":2100,"op":"SLOAD","pc":133},....

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@orijbot
Copy link

orijbot commented Sep 15, 2021

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #565 (28a6b81) into main (116de54) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   53.39%   53.39%           
=======================================
  Files          64       64           
  Lines        5128     5128           
=======================================
  Hits         2738     2738           
  Misses       2263     2263           
  Partials      127      127           
Impacted Files Coverage Δ
x/evm/keeper/grpc_query.go 65.38% <0.00%> (ø)

@crypto-facs crypto-facs changed the title add logconfig parameters to traceconfig RPC: Fix TraceConfig parameter for tracers Sep 15, 2021
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze
Copy link
Contributor

for future ref, embed won't work here: gogo/protobuf#380

@fedekunze fedekunze merged commit 0463c8b into evmos:main Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC: DisableStorage parameter not working on debug_traceTransaction
3 participants