Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

all: add benchmarks to core components #493

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Aug 26, 2021

Description

Add benchmarks to core components, so we can do continuous benchmarking using Orijtech bencher.

Fixes #480


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cuonglm
Copy link
Contributor Author

cuonglm commented Aug 26, 2021

cc @odeke-em

Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cuonglm!

crypto/ethsecp256k1/benchmark_test.go Show resolved Hide resolved
@cuonglm cuonglm force-pushed the cuonglm/issue-480 branch from 59c592b to 26c2dde Compare August 26, 2021 07:36
@fedekunze fedekunze enabled auto-merge (squash) August 26, 2021 08:12
@fedekunze fedekunze merged commit 4b11ac6 into evmos:main Aug 26, 2021
@orijbot
Copy link

orijbot commented Aug 26, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: write all-inclusive Go style benchmarks and a couple of micro benchmarks
4 participants