Add Ethereum Tooling Guides #474
Conversation
There was a problem hiding this comment.
Looks good! Love the tabs too. Left a few questions too (specially around the 2 metamask guides)
I'd suggest you download the markdownlint plug-in (if you are using VS Code): https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
docs/guides/README.md
Outdated
| @@ -13,7 +13,9 @@ parent: | |||
| * [Keyring](./keys-wallets/keyring) | |||
| * [Metamask](./keys-wallets/metamask) | |||
There was a problem hiding this comment.
should we remove this one?
There was a problem hiding this comment.
Kept this one and merged the other into it
docs/guides/tools/metamask.md
Outdated
| order: 1 | ||
| --> | ||
|
|
||
| # MetaMask: Connecting to Ethermint |
There was a problem hiding this comment.
how does this guide relate to the one on guides/keys-wallets/?
There was a problem hiding this comment.
wondering if we should merge them
docs/guides/tools/truffle.md
Outdated
|
|
||
| First, install the latest Truffle version on your machine globally. | ||
|
|
||
| ```bash | ||
| yarn install truffle -g | ||
| ```shell |
There was a problem hiding this comment.
curious about the use of bash vs shell? should we enforce one over the other?
There was a problem hiding this comment.
Actually, after doing some research the answer is no. The lexers Github-flavored md uses are different than vuepress it seems.
shell is just an alias of bash for vuepress, so using bash is fine. Full list here.
Codecov Report
@@ Coverage Diff @@
## main #474 +/- ##
===========================================
- Coverage 64.11% 50.38% -13.73%
===========================================
Files 11 51 +40
Lines 1346 5005 +3659
===========================================
+ Hits 863 2522 +1659
- Misses 454 2373 +1919
- Partials 29 110 +81
|
… into jolube/docs-eth-tooling
Closes: #XXX
Description
This PR improves on existing Ethereum tooling guides (Truffle, Remix) in addition to adding new ones (Hardhat, Metamask). The guides now also target testnet configs.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)