Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

server: configurable tracer #434

Merged
merged 9 commits into from
Aug 16, 2021
Merged

server: configurable tracer #434

merged 9 commits into from
Aug 16, 2021

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Aug 12, 2021

attempt to unblock @crypto-facs with the debug_traceTransaction

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added Type: Build codebase build process Type: Docs Improvements or additions to documentation Type: Tests issues and PR related to tests labels Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #434 (934197e) into main (353455d) will decrease coverage by 0.13%.
The diff coverage is 39.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   50.72%   50.58%   -0.14%     
==========================================
  Files          49       50       +1     
  Lines        4885     4928      +43     
==========================================
+ Hits         2478     2493      +15     
- Misses       2300     2328      +28     
  Partials      107      107              
Impacted Files Coverage Δ
x/evm/types/tracer.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 70.66% <33.33%> (-0.23%) ⬇️
server/config/config.go 26.66% <36.36%> (+8.80%) ⬆️
app/ante/eth.go 90.35% <100.00%> (ø)
app/app.go 83.46% <100.00%> (+0.08%) ⬆️
x/evm/keeper/keeper.go 70.68% <100.00%> (+0.16%) ⬆️
x/evm/keeper/state_transition.go 58.47% <100.00%> (+0.35%) ⬆️

@evmos evmos deleted a comment from netlify bot Aug 12, 2021
@fedekunze fedekunze marked this pull request as ready for review August 12, 2021 15:45
@crypto-facs
Copy link
Contributor

crypto-facs commented Aug 15, 2021

This is awesome man! Thanks for taking care of this. I would need to change something here for this to work with what I need.

So instead of just being able to configure the tracer type by a flag, I need to be able to use a different tracer type when creating a new EVM through the NewEVM function. For this, the trace type would need to be a param on the VMConfig function instead of getting it from the keeper.

In Go Ethereum they do this https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/api.go#L816 .. where they have the ability to pass a config to the NewEVM creation where they can specific the type of tracer to use.

@fedekunze
Copy link
Contributor Author

@crypto-facs how about now?

@fedekunze fedekunze requested a review from crypto-facs August 16, 2021 09:19
@crypto-facs
Copy link
Contributor

Now its perfect! 👌 🚀 Thanks for taking care of this

@fedekunze fedekunze enabled auto-merge (squash) August 16, 2021 09:37
@fedekunze fedekunze merged commit cc3b2ff into main Aug 16, 2021
@fedekunze fedekunze deleted the fedekunze/server-tracer branch August 16, 2021 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Build codebase build process Type: Docs Improvements or additions to documentation Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants