This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
feat: import ethermint without forking #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:JSON-RPC
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 52.59% 51.97% -0.62%
==========================================
Files 46 47 +1
Lines 4609 4660 +51
==========================================
- Hits 2424 2422 -2
- Misses 2086 2139 +53
Partials 99 99
|
fedekunze
commented
Jul 28, 2021
| @@ -42,29 +42,6 @@ func InitConfig(cmd *cobra.Command) error { | |||
| return viper.BindPFlag(cli.OutputFlag, cmd.PersistentFlags().Lookup(cli.OutputFlag)) | |||
| } | |||
|
|
|||
| // GenerateChainID wraps a cobra command with a RunE function with base 10 integer chain-id random generation | |||
| // when a chain-id is not provided. | |||
| func GenerateChainID(baseCmd *cobra.Command) *cobra.Command { | |||
fedekunze
commented
Jul 28, 2021
Comment on lines
+20
to
+24
| # API defines a list of JSON-RPC namespaces that should be enabled | ||
| api = "{{ .EVMRPC.API }}" | ||
|
|
||
| # EnableUnsafeCORS defines if CORS should be enabled (unsafe - use it at your own risk) | ||
| enable-unsafe-cors = "{{ .EVMRPC.EnableUnsafeCORS }}" |
There was a problem hiding this comment.
these were missing
fedekunze
commented
Jul 28, 2021
| @@ -47,8 +46,3 @@ func ParseChainID(chainID string) (*big.Int, error) { | |||
|
|
|||
| return chainIDInt, nil | |||
| } | |||
|
|
|||
| // GenerateRandomChainID returns a random chain-id in the valid format. | |||
| func GenerateRandomChainID() string { | |||
fedekunze
commented
Jul 28, 2021
|
|
||
| // HDPathIterator receives a base path as a string and a boolean for the desired iterator type and | ||
| // returns a function that iterates over the base HD path, returning the string. | ||
| func NewHDPathIterator(basePath string, ledgerIter bool) (HDPathIterator, error) { |
There was a problem hiding this comment.
I had to create an iterator for the personal API, otherwise, every new account that is created will use the same hdpath
|
tested locally with a dummy app from starport |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #293
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)